Add: GetJob, DeleteJob, ListJobsByPrefix #79
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cassandra Coyle <[email protected]>
…leteJob Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
leo-scalingo
requested changes
Feb 8, 2024
There was a problem hiding this comment.
Hi @cicoyle
Thanks for your contribution.
From what I understand, you're looking to make it more dynamic, our usage so far was to initialize all jobs at the beginning of a sofware.
It's ok to do so, but in this case, entries should by protected by a Mutex to prevent race conditions, can you handle that?
Thanks
|
Closing this PR since our needs went beyond the original intent of this library. We have forked this repo and significantly re-written it for our Distributed Scheduler needs, see here if curious :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to add the rest of the CRUD methods, such that a user can use this pkg to:
Not sure if there was a reason the
GetJob,DeleteJob,ListJobsByPrefixweren't already added?This PR closes this issue